Initial step for adding AssemblyBuilder.Save implementation #83554

buyaa-n · 2023-03-16T21:35:20Z

We decided to have smaller PRs with simpler changes instead of one big PR. Here is what this PR doing:

Moving the prototyping work into runtime
Made some necessary refactoring
Few more simple changes (save simple field, value type)
Not introducing new public APIs in ref, new APIs proposal and review will be followed

Contributes to #62956

ghost · 2023-03-16T21:35:38Z

Tagging subscribers to this area: @dotnet/area-system-reflection-emit
See info in area-owners.md if you want to be subscribed.

Issue Details

We decided to have smaller PRs with simpler changes instead of one big PR. Here is what this PR doing:

Moving the prototyping work into runtime
Made some necessary refactoring
Few more simple changes (save simple field, value type)
Not introducing new public APIs in ref, new APIs proposal and review will be followed

Contributes to #62956

Author:	buyaa-n
Assignees:	-
Labels:	`area-System.Reflection.Emit`
Milestone:	-

src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/PersistableAssemblyBuilder.cs

src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/PersistableFieldBuilder.cs

src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/PersistableTypeBuilder.cs

src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/SignatureHelper.cs

src/libraries/System.Reflection.Emit/tests/System.Reflection.Emit.Tests.csproj

src/libraries/System.Reflection.Emit/src/Resources/Strings.resx

src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/ModuleBuilderImpl.cs

src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/AssemblyBuilderImpl.cs

src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/ModuleBuilderImpl.cs

src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/MethodBuilderImpl.cs

src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/SignatureHelper.cs

src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/AssemblyBuilderImpl.cs

src/coreclr/System.Private.CoreLib/src/System/Reflection/Emit/RuntimeTypeBuilder.cs

src/libraries/System.Reflection.Emit/tests/PersistableAssemblyBuilder/AssemblyTools.cs

...System.Reflection.Emit/tests/PersistableAssemblyBuilder/AssemblySaveTestsWithVariousTypes.cs

src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/ModuleBuilderImpl.cs

src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/SignatureHelper.cs

src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/TypeBuilderImpl.cs

...System.Reflection.Emit/tests/PersistableAssemblyBuilder/AssemblySaveTestsWithVariousTypes.cs

src/libraries/System.Reflection.Emit/tests/PersistableAssemblyBuilder/AssemblyTools.cs

...System.Reflection.Emit/tests/PersistableAssemblyBuilder/AssemblySaveTestsWithVariousTypes.cs

src/coreclr/System.Private.CoreLib/src/System/Reflection/Emit/RuntimeAssemblyBuilder.cs

src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/AssemblyBuilderImpl.cs

src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/MetadataHelper.cs

src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/ModuleBuilderImpl.cs

src/libraries/System.Reflection.Emit/tests/PersistableAssemblyBuilder/AssemblyTools.cs

...System.Reflection.Emit/tests/PersistableAssemblyBuilder/AssemblySaveTestsWithVariousTypes.cs

src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/MetadataHelper.cs

…t/MetadataHelper.cs Co-authored-by: Jan Kotas <[email protected]>

...System.Reflection.Emit/tests/PersistableAssemblyBuilder/AssemblySaveTestsWithVariousTypes.cs

jkotas

LGTM otherwise

buyaa-n · 2023-04-01T00:16:44Z

All failures are known, thanks for the throughout review @jkotas @steveharter

src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/ModuleBuilderImpl.cs

buyaa-n and others added 9 commits February 24, 2023 11:15

Initial import AB.Save

247cc65

Move code from S.R.Metadata to S.R.Emit

fefba4f

Merge branch 'main' of https://github.com/dotnet/runtime into ab-save

063a774

Add additional proj refs for VS

c4da1d6

Merge branch 'ab-save' of github.com:buyaa-n/runtime into ab-save

f0056ac

Some refactoring, handle CustomAttributes for Assembly/Module

625539e

Save custom attributes for method/fields

7df8da2

Remove public APIs until API shape approved

feb65a4

Remove custom attibutes related changes

d78c7d0

buyaa-n requested review from jkotas, steveharter and AaronRobinsonMSFT March 16, 2023 21:35

dotnet-issue-labeler bot added the area-System.Reflection.Emit label Mar 16, 2023

ghost assigned buyaa-n Mar 16, 2023